Skip to content

gh-159340: Detect partial reductions in expected compiler warnings - #159341

Draft
esadomer wants to merge 2 commits into
python:mainfrom
esadomer:fix-20261013-09-warnings-partial-improvements
Draft

esadomer wants to merge 2 commits into
python:mainfrom
esadomer:fix-20261013-09-warnings-partial-improvements

Conversation

@esadomer

@esadomer esadomer commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The improvement check only examines files with no remaining warnings, so a reduction from two warnings to one is missed. Compare the actual count for every finite ignore rule, including zero, while preserving wildcard rules.

Fixes #159340.

Validation (Windows debug build): both isolated tests passed (count boundaries and CLI partial improvements); reduced and zero-count cases failed before the fix. The isolated patch applies cleanly to the base revision.

Merge coordination: #159337 and #159339 add different regression tests to the same new test_check_warnings.py module. After the first PR merges, the remaining branches need to incorporate the landed tests before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect partial reductions in expected compiler warnings

1 participant