Repository navigation
Conversation
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The improvement check only examines files with no remaining warnings, so a reduction from two warnings to one is missed. Compare the actual count for every finite ignore rule, including zero, while preserving wildcard rules.
Fixes #159340.
Validation (Windows debug build): both isolated tests passed (count boundaries and CLI partial improvements); reduced and zero-count cases failed before the fix. The isolated patch applies cleanly to the base revision.
Merge coordination: #159337 and #159339 add different regression tests to the same new
test_check_warnings.pymodule. After the first PR merges, the remaining branches need to incorporate the landed tests before merging.