Repository navigation
Fix the macOS app not finding librtcheck.dylib, and smoke test the release zips - #197
Merged
Merged
Conversation
…, and smoke test the release zips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published macOS binaries for
v2.0.0-beta1andv2.0.0-beta2fail to start on any machine but the CI runner that built them:The app bundles
Contents/Libraries/librtcheck.dylib, but the binary's only rpath was the build tree's, so it never looked in the bundle. Present since rtcheck was added (#156). CI didn't catch it because every step that runs pluginval does so on the build machine, where the build-tree path exists.What
CMakeLists.txt: on Apple, when rtcheck is enabled, add@executable_path/../Librariesto pluginval'sBUILD_RPATH. It is searched first, before the build-tree rpath CMake adds.build.yaml: new "Smoke test the zip" step on all three platforms. It extracts the zip that is about to be uploaded into$RUNNER_TEMP/smokeand runspluginval --versionfrom there, so a package that only works on the build machine fails CI before it is released. On macOS it first moves the build's_deps/rtcheck-builddirectory aside, because the binary also has that path as an rpath and it exists on the runner; with it hidden, only the dylib bundled in the app can be found, as on a user's machine.CHANGELIST.md: noted the fix.Testing (macOS, locally)
Added
@executable_path/../Librariesby hand to a copy of the publishedv2.0.0-beta2binary (and re-signed it ad hoc): it then starts and prints its version.Built a Release app from this branch: its rpaths are
@executable_path/../Librariesthen the build tree. With the build-tree rpath deleted from a copy (simulating another machine), it starts andrun-testsgives the same result as the unmodified build. The one failure,AllocatorInterceptorTests / Ensure array allocations are caught, is pre-existing and also fails on the unmodified binary.Ran the smoke step's logic locally: the Release build from this branch passes; an older build without the fix fails with the same
Library not loaded: @rpath/librtcheck.dyliberror (exit 134). So the step would have caught this bug.After merging
Tag
v2.0.0-beta3and point the actions at it (#196 currently bumps them to beta2).