Repository navigation
GitHub Actions: download pluginval v2.0.0-beta3 by default - #196
Merged
Merged
Conversation
…acOS binary doesn't start)
drowaudio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
pluginval-versiondefault invalidate/action.ymlandacceptance/action.yml(and the README tables) fromv2.0.0-beta1tov2.0.0-beta3.beta3 is the first v2 pre-release whose macOS binary starts outside the build machine (#197 fixed the
librtcheck.dylibrpath; the beta1 and beta2 macOS binaries fail withLibrary not loaded: @rpath/librtcheck.dylib). It also includes the discrete parameter state restoration test (#191) and the fixes from #198.This PR originally bumped to beta2; it was switched to beta3 once the macOS problem was found.
Testing
Ran both actions locally on macOS with no
pluginval-path, so they downloadedhttps://github.com/Tracktion/pluginval/releases/download/v2.0.0-beta3/pluginval_macOS.zip:validateon a dogfood plugin: passed, 17 tests.acceptanceon two configs withpluginset: both passed.The dogfood CI steps use
pluginval-path, so they don't exercise the default; the Linux and Windows downloads haven't been run.