Repository navigation
fix(webapp): convert epoch ms to BigInt before nanosecond multiplication #5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+45
−4
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { afterEach, describe, expect, it, vi } from "vitest"; | ||
| import { | ||
| calculateDurationFromStart, | ||
| convertDateToNanoseconds, | ||
| getNowInNanoseconds, | ||
| } from "~/v3/eventRepository/common.server"; | ||
|
|
||
| // 1700000000001 * 1e6 is not representable as a double (spacing is 256 at ~1.7e18), | ||
| // so Number multiplication before BigInt conversion rounds it to ...000999936. | ||
| const unsafeMs = 1_700_000_000_001; | ||
| const unsafeNs = 1_700_000_000_001_000_000n; | ||
|
|
||
| describe("eventRepository nanosecond conversions", () => { | ||
| afterEach(() => { | ||
| vi.useRealTimers(); | ||
| }); | ||
|
|
||
| it("convertDateToNanoseconds keeps exact precision beyond MAX_SAFE_INTEGER", () => { | ||
| expect(convertDateToNanoseconds(new Date(unsafeMs))).toBe(unsafeNs); | ||
| }); | ||
|
|
||
| it("getNowInNanoseconds keeps exact precision beyond MAX_SAFE_INTEGER", () => { | ||
| vi.useFakeTimers(); | ||
| vi.setSystemTime(unsafeMs); | ||
|
Comment on lines
+23
to
+24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| expect(getNowInNanoseconds()).toBe(unsafeNs); | ||
| expect(getNowInNanoseconds() % 1_000_000n).toBe(0n); | ||
| }); | ||
|
|
||
| it("calculateDurationFromStart is exact for sub-millisecond-sensitive end times", () => { | ||
| const startTime = convertDateToNanoseconds(new Date(unsafeMs - 1)); | ||
|
|
||
| expect(calculateDurationFromStart(startTime, new Date(unsafeMs))).toBe(1_000_000); | ||
| }); | ||
|
|
||
| it("calculateDurationFromStart applies the minimum duration", () => { | ||
| const startTime = convertDateToNanoseconds(new Date(unsafeMs - 1)); | ||
|
|
||
| expect(calculateDurationFromStart(startTime, new Date(unsafeMs), 5_000_000)).toBe(5_000_000); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Conversion tests are not colocated
The new conversion tests live outside the event repository. The repository's testing guide requires new test files beside the source they exercise.
Was this helpful? React with 👍 or 👎 to provide feedback.