Repository navigation
feat(iaas): support description field for network and network area cmds - #1673
Open
cgoetz-inovex wants to merge 3 commits into
Open
cgoetz-inovex wants to merge 3 commits into
cgoetz-inovex wants to merge 3 commits into
Conversation
| cmd.Flags().StringToString(labelFlag, nil, "Labels are key-value string pairs which can be attached to a network. E.g. '--labels key1=value1,key2=value2,...'") | ||
| } | ||
|
|
||
| func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) { |
Contributor
There was a problem hiding this comment.
Not directly related to your changes, but i noticed that you can invoke stackit network update without any flags and the cli will not reject it. might be worth fixing
| table.AddRow( | ||
| network.Id, | ||
| network.Name, | ||
| utils.PtrString(network.Description), |
Contributor
There was a problem hiding this comment.
nitpick: Large descriptions may make the table very wide. Maybe it is worth to limit the description for the list command? alb plans does something like this: utils.Truncate(item.Description, 70)
|
Caution No coverage for base commit f020712 was found, so this report compares against its ancestor 9821c0f (1 commit earlier) Merging this branch will increase overall coverage
Coverage detailsCompared to commit 9821c0f (run #38861132342)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1234
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)