Skip to content

feat(iaas): onboard vpc routing table static route commands - #1656

Merged
marceljk merged 1 commit into
mainfrom
feat/STACKITCLI-466-onboard-vpc-routing-table-static-route-commands
Oct 13, 2026
Merged

marceljk merged 1 commit into
mainfrom
feat/STACKITCLI-466-onboard-vpc-routing-table-static-route-commands

Conversation

@marceljk

Copy link
Copy Markdown
Contributor

Description

relates to STACKITCLI-466

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk
marceljk requested a review from a team as a code owner October 12, 2026 14:11
Comment thread internal/cmd/alpha/vpc/routingtable/routingtable.go
@rubenhoenle

Copy link
Copy Markdown
Member

No review, just one hint: Maybe we want to update the descriptions of the SNA routing table commands to explicitly state that they are for managing SNA routing tables.

Short: "Manage routing-tables and its according routes",

Just to make sure users don't mess things up and go with the wrong command for their setup. The whole SNA/VPC thing is quite confusing from a user perspective I guess 😅

cgoetz-inovex
cgoetz-inovex previously approved these changes Oct 12, 2026
@marceljk
marceljk force-pushed the feat/STACKITCLI-466-onboard-vpc-routing-table-static-route-commands branch from 257e8b3 to 22d39bb Compare October 13, 2026 11:49
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/create 62.32% (+62.32%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/delete 36.11% (+36.11%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/describe 74.00% (+74.00%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/list 68.63% (+68.63%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/update 52.08% (+52.08%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils 98.00% (+26.57%) 🌟
Coverage details

Compared to commit d24f3d7 (run #38390247214)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/routingtable.go 0.00% (ø) 9 (+1) 0 9 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/create/create.go 62.32% (+62.32%) 69 (+69) 43 (+43) 26 (+26) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/delete/delete.go 36.11% (+36.11%) 36 (+36) 13 (+13) 23 (+23) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/describe/describe.go 74.00% (+74.00%) 50 (+50) 37 (+37) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/list/list.go 68.63% (+68.63%) 51 (+51) 35 (+35) 16 (+16) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/staticroute.go 0.00% (ø) 8 (+8) 0 8 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/update/update.go 52.08% (+52.08%) 48 (+48) 25 (+25) 23 (+23) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/vpc.go 0.00% (ø) 11 0 11
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils/utils.go 98.00% (+26.57%) 50 (+29) 49 (+34) 1 (-5) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/routingtable/staticroute/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils/utils_test.go

@marceljk
marceljk merged commit 024610f into main Oct 13, 2026
5 checks passed
@marceljk
marceljk deleted the feat/STACKITCLI-466-onboard-vpc-routing-table-static-route-commands branch October 13, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants