Repository navigation
feat(versioned): Support conversion tracking through enums - #1294
Merged
Merged
Conversation
sbernauer
added this pull request to stack #1295
October 9, 2026 14:04
13 tasks
sbernauer
commented
Oct 12, 2026
With experimental_conversion_tracking enabled, versioned enums now implement TrackingFrom instead of From, in line with structs. Variants marked with as an additional path segment (eg. `$.connector.Iceberg.field`). Also fix the generated From impls for variants with multiple unnamed fields, which were missing separating commas.
Techassi
force-pushed
the
feat/track-enums
branch
from
October 12, 2026 15:14
5b2d911 to
faee475
Compare
Techassi
force-pushed
the
feat/track-enums
branch
from
October 16, 2026 08:40
af463b6 to
dcd17be
Compare
This was referenced Oct 16, 2026
Techassi
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on top of #1293!
With
experimental_conversion_trackingenabled, versioned enums now implementTrackingFrominstead ofFrom, in line with structs.Also fix the generated
Fromimpls for variants with multiple unnamed fields, which were missing separating commas.Definition of Done Checklist
Author
Reviewer
Acceptance