Repository navigation
Add cancellable File::file_sync operations. - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic
Fileconsumers can now explicitly synchronize completed writes throughfile_sync(file, mode, cancellation).await.SyncMode::Allrequests contents and metadata;SyncMode::Datapermits omitting metadata unrelated to retrieving the contents.Linux io_uring uses native
Fsyncrequests and checks opcode support during initialization. Buffer-free synchronization requests share submission, cancellation, and terminal-completion tracking with transfers. Readiness and Tokio usesync_all/sync_dataon their existing file-operation pools, while the in-memory implementation completes immediately without modeling crash durability.The operation is lazy, reports OS completion and errors, leaves the cursor unchanged, and retains the file through backend access even if its waiter disappears. Blocking workers check cancellation before execution; started calls preserve their result. Ring cancellation is best effort and successful completion wins a concurrent cancellation request. Callers must await preceding writes; synchronization does not order concurrent work, flush application buffers, or synchronize a parent directory entry.
This adds a required method to
File, so external implementations must supply it. Update the design, public documentation, and release notes alongside shared backend contracts and cancellation/resource-lifetime coverage.