Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124323428. |
meta-codesync
Bot
changed the title
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 13, 2026
react#59026) Summary: Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas: - iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`. - Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`. - ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`. Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124323428
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 08:39
b4ae527 to
ddadc6f
Compare
Summary: Several "for frameworks" headers included fine-grained headers of public modules directly. A framework author includes a for-frameworks header directly, outside any umbrella, so under `RN_STRICT_API` those includes hit the public module's `UmbrellaGuard.h` `#error`, which `RN_ALLOW_FRAMEWORKS` does not suppress. Switch them to the module umbrellas: - Image component (`ImageComponentDescriptor.h`, `ImageEventEmitter.h`, `ImageProps.h`, `ImageShadowNode.h`, `ImageState.h`): `<React/View.h>`, `<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/ImageManager.h>`. - `ComponentDescriptorFactory.h`: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/ComponentRegistry.h>`. - `react/renderer/core` `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h`, `ReactRootViewTagGenerator.h`: `<React/RendererCore.h>`. - `DefaultTurboModules.h`: `<React/NativeModuleCore.h>`. - iOS/macOS `RCTInstance.h` and `RCTContextContainerHandling.h`: `<React/CallInvoker.h>`, `<React/Utils.h>`. `ImageProps.h` now reaches the image manager through `<React/ImageManager.h>`, which also pulls in the platform-specific `ImageRequestParams.h`. `LayoutAnimationKeyFrameManager.cpp` included `ImageProps.h` without using it; that build unit cannot see the platform image manager headers in the Swift Package Manager and CocoaPods `React-Fabric` targets, so the unused include is removed. Includes of for-frameworks headers in the same module stay direct, since umbrellas do not re-export them. The `react/renderer/core` headers and `ComponentDescriptorFactory.h` now include their own module's umbrella, so the CMake `react_renderer_core` and `react_renderer_componentregistry` targets expose their umbrella directory as `PUBLIC` instead of `INTERFACE`: core's own sources (`EventEmitter.cpp`, `Props.cpp`, `ShadowNode.cpp`, ...) include these headers and must resolve `<React/RendererCore.h>` too. Each umbrella is a superset of the headers it replaces, so no declarations are lost. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Differential Revision: D124320010
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 13, 2026
react#59026) Summary: Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas: - iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`. - Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`. - ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`. Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124323428
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 08:42
ddadc6f to
f42d2c9
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 13, 2026
react#59026) Summary: Pull Request resolved: react#59026 Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas: - iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`. - Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`. - ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`. Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124323428
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 08:43
f42d2c9 to
452305e
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 13, 2026
react#59026) Summary: Pull Request resolved: react#59026 Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas: - iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`. - Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`. - ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`. Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124323428
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 08:48
452305e to
444453b
Compare
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 15:54
444453b to
6a7e5b0
Compare
Summary: Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas: - iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`. - Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`. - ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`. Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`. With `use_frameworks!`, a `<React/...>` umbrella lives only in its owning pod's framework headers, which CocoaPods adds to dependents' search paths only for pods in `ReactNativePodsUtils.stable_umbrella_frameworks`. React-Core now reaches the `React-cxxreact` and `React-callinvoker` umbrellas, so add both pods to that list; otherwise the dynamic frameworks build fails with `'React/JSBigString.h' file not found`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124323428
coado
force-pushed
the
export-D124323428
branch
from
October 13, 2026 16:00
6a7e5b0 to
29f9fc6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under
RN_STRICT_APIany app or library including them hits the public module'sUmbrellaGuard.h#error. Switch them to the module umbrellas:RCTCallInvoker.h,RCTBridgeProxy+Cxx.h:<React/CallInvoker.h>;NSDataBigString.h:<React/JSBigString.h>.react/fabric/AnimatedPropBufferEncoder.h:<React/RendererCore.h>;react/runtime/jni/JJSTimerExecutor.h,JReactInstance.h:<React/RuntimeExecutor.h>.ImageLoaderModule.h,NativeExceptionsManager.h:<React/Bridging.h>;IMountingManager.h,RunLoopObserverManager.h:<React/RendererCore.h>;ReactHost.h:<React/CallInvoker.h>,<React/NativeModuleCore.h>;ReactInstanceConfig.h:<React/Debug.h>.Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without
RN_STRICT_API.With
use_frameworks!, a<React/...>umbrella lives only in its owning pod's framework headers, which CocoaPods adds to dependents' search paths only for pods inReactNativePodsUtils.stable_umbrella_frameworks. React-Core now reaches theReact-cxxreactandReact-callinvokerumbrellas, so add both pods to that list; otherwise the dynamic frameworks build fails with'React/JSBigString.h' file not found.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D124323428