Skip to content

Use umbrellas in popup-menu-android generated headers (#58906) - #58906

Closed
j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D123850428
Closed

j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D123850428

Conversation

@j-piasecki

@j-piasecki j-piasecki commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Refresh the checked-in codegen headers of react-native-popup-menu-android to include React Native through module umbrellas instead of fine-grained headers, matching current codegen output. Each umbrella re-exports the headers it replaces, so there is no functional change.

Changelog: [Internal]

Differential Revision: D123850428

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Oct 7, 2026
@meta-codesync

meta-codesync Bot commented Oct 7, 2026

Copy link
Copy Markdown

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123850428.

@meta-codesync meta-codesync Bot changed the title Use umbrellas in popup-menu-android generated headers Use umbrellas in popup-menu-android generated headers (#58906) Oct 12, 2026
j-piasecki added a commit to j-piasecki/react-native that referenced this pull request Oct 12, 2026
Summary:

Refresh the checked-in codegen headers of `react-native-popup-menu-android` to include React Native through module umbrellas instead of fine-grained headers, matching current codegen output. Each umbrella re-exports the headers it replaces, so there is no functional change.

Changelog: [Internal]

Differential Revision: D123850428
Summary:

Refresh the checked-in codegen headers of `react-native-popup-menu-android` to include React Native through module umbrellas instead of fine-grained headers, matching current codegen output. Each umbrella re-exports the headers it replaces, so there is no functional change.

Changelog: [Internal]

Differential Revision: D123850428
@meta-codesync meta-codesync Bot closed this in 51c4ef2 Oct 13, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 13, 2026
@meta-codesync

meta-codesync Bot commented Oct 13, 2026

Copy link
Copy Markdown

This pull request has been merged in 51c4ef2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant