Skip to content

Model missing readline history entries as optional strings - #16524

Open
xiehuanyi wants to merge 1 commit into
python:mainfrom
xiehuanyi:fix/readline-history-optional-20261013
Open

xiehuanyi wants to merge 1 commit into
python:mainfrom
xiehuanyi:fix/readline-history-optional-20261013

Conversation

@xiehuanyi

Copy link
Copy Markdown
Contributor

Make readline.get_history_item accept index protocol objects and return str | None, matching the implementation when no history entry exists.

Agent: OpenAI Codex.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 18:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants