Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1249.
A decorated method has no entry in
ClassIR.method_decls, but the function below the decorators is inClassIR.methods. For__new__the code generator used both, and the result didn't work for any caller:tp_newcalled the function below the decorators directly, so a native call skipped the decorators.__new__function that callstp_new. Setting the result on the class makes Python replacetp_new, which fails the safety check of that built-in function. Every call that isn't a native constructor call raisedTypeError: C.__new__(C) is not safe, use object.__new__().__new__takes other arguments than__init__, the generated C didn't compile (too many arguments to function 'CPyDef_C_____new__').__new__in the type dict came from the method table, whose flags don't match the wrapper function of__new__. Instantiating the class crashed.