[mypyc] Fix super() method calls in class methods and generators

[rheard]

Fixes mypyc/mypyc#1247.

super().f() in a class method called a class method of a native base class with type(cls), the metaclass, instead of cls:

class A:
    @classmethod
    def make(cls) -> str:
        return cls.__name__


class B(A):
    @classmethod
    def make(cls) -> str:
        return "B:" + super().make()


print(B.make())  # B:B, compiled: B:type

translate_super_method_call() binds methods of native base classes statically. It took the first argument of the function being compiled as the object, and type() of it for a class method.

The function now works with the variable that super() binds: the second argument of super(B, self), or the first argument of the enclosing function for the zero-argument form. It reads that variable through the symbol table, which gives the right value in generators and closures.

[p-sawicki]

i think this lookup will have to be moved before argument evaluation, otherwise it's possible to reassign self in the argument expression and break evaluation order:

class A:
    label: str

    def __init__(self, label: str) -> None:
        self.label = label

    def method(self, unused: int) -> str:
        return self.label

class B(A):
    def method(self, unused: int) -> str:
        def change_receiver() -> int:
            nonlocal self
            self = B("replacement")
            return 0

        return super().method(change_receiver())

def result() -> str:
    return B("original").method(0)

[rheard]

Good catch, this has been addressed.

[p-sawicki]

thanks!