Repository navigation
[3.15] gh-159440: Pass --work-tree to the git commands used for the version tag (GH-159442) - #159443
Merged
Merged
Conversation
…rsion tag (pythonGH-159442) `--git-dir` alone does not imply a work tree, so in an out-of-tree build git checked the build directory, and every tracked file looked deleted: `sys.version` always carried a spurious "-dirty" suffix. (cherry picked from commit 637fb369c751efb0564e35757318e72874e21619) Co-authored-by: sendaoYan <yansendao@hygon.cn>
miss-islington
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
October 15, 2026 04:18
itamaro
enabled auto-merge (squash)
October 15, 2026 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--git-diralone does not imply a work tree, so in an out-of-tree buildgit checked the build directory, and every tracked file looked deleted:
sys.versionalways carried a spurious "-dirty" suffix.(cherry picked from commit 637fb36)
Co-authored-by: sendaoYan yansendao@hygon.cn