Repository navigation
gh-159041: Fix asyncio task tracking during thread state clear - #159319
Open
mikegit123git wants to merge 1 commit into
Open
mikegit123git wants to merge 1 commit into
mikegit123git wants to merge 1 commit into
Conversation
mikegit123git
requested review from
1st1,
FFY00,
ZeroIntensity,
asvetlov,
ericsnowcurrently,
kumaraditya303 and
willingc
as code owners
October 13, 2026 14:29
|
The following commit authors need to sign the Contributor License Agreement: |
BHUVANSH855
reviewed
Oct 13, 2026
BHUVANSH855
left a comment
BHUVANSH855
left a comment
Contributor
There was a problem hiding this comment.
Kindly sign CLA, so that maintainers can begin with review process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159041
Summary
PyThreadState_Clear()currently merges the thread state's asyncio tasklist before the
Py_CLEAR()calls run finalizers. A finalizer can createan asyncio Task after the merge, leaving the Task linked to a thread state
that is subsequently freed.
Move the task-list merge after all finalizer-capable cleanup operations and
add a regression test for a Task created by a thread-state finalizer.
Tests
./python -m test test_asyncio.test_free_threading -j0(GIL build)./python -m test test_asyncio.test_free_threading -j0(free-threaded build)make patchcheckasyncioTaskcreated from a finalizer duringPyThreadState_Clear()registers into memory that is about to be freed (3.14 regression) #159041