Repository navigation
Conversation
Member
|
Use hasThis instead of getThis |
Contributor
Author
|
Done in 5ffdb80. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finfo_file()andfinfo::file()share one implementation, and on PHP-8.4 the argument number for the empty and null byte checks is only switched formime_content_type(). So the method reportsArgument #2 ($flags)while$filenameis argument 1 there. This uses 1 when called as a method too.PHP-8.5 and master hardcode
2for the empty check infinfo_file()instead, so that part will need adjusting on merge up.Fixes GH-24289