Repository navigation
Conversation
Contributor
|
Nice. Does this work correctly if the |
When the callback denies the push, or throws and leaves the return value undefined, libcurl destroys the easy handle itself. The wrapper kept a stale ch->cp after a throw, and in both cases never released the CurlHandle it had just created, so each denied push leaked one wrapper and permanently bumped the parent's clone counter. Clear ch->cp and drop the callback's reference instead. curl_free_obj() now keys its early return on ch->clone, which is unset only when the constructor failed, so a handle whose easy handle libcurl already freed still releases its handlers when its last reference goes, including when the callback kept it.
iliaal
force-pushed
the
promote/curl-push-deny-leak
branch
from
October 13, 2026 11:56
9177fd8 to
ec8ddd8
Compare
Member
Author
|
Ah, it didn't: the kept handle's handlers were freed while it stayed reachable, so a later GC run could read freed memory. The callback now only clears the easy handle and drops its own reference, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the callback denies the push, or throws and leaves the return value undefined, libcurl destroys the easy handle itself, but the wrapper kept a stale ch->cp after a throw and never released the CurlHandle it had just created, so each denied push leaked one wrapper and permanently bumped the parent's clone counter. The callback now clears ch->cp and drops its reference, and curl_free_obj() keys its constructor-failure exit on ch->clone, so the handlers are released whenever the last reference goes, including when the callback keeps the handle. The new tests need Caddy, so they only run in the lanes that have it.