Repository navigation
✨ report ClusterObjectSet rollout as Ready=False/ObjectsNotReady - #3009
Conversation
Collapse the in-transition RollingOut path and the ProbeFailure path into a
single ObjectsNotReady reason on the ClusterObjectSet Ready condition. The
condition message reports the count of not-ready objects ("N object(s) are not
yet ready."); per-object probe detail is logged at V(1) rather than carried in
the condition, and the ProgressDeadlineExceeded "last status" uses a generic
summary so the reconstructed ClusterExtension Progressing message stays stable.
Remove ClusterObjectSetReasonProbeFailure; COS no longer emits the shared
RollingOut reason. ClusterExtension Progressing still reports RollingOut while
rolling out.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
perdasilva
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (8 skipped: 8… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title is concise, specific, and accurately describes the main change: reporting ClusterObjectSet rollout as Ready=False with reason ObjectsNotReady. Description check The description clearly explains the motivation, behavior changes, scope, compatibility impact, and test and documentation updates. It does not include the template's Reviewer Checklist section, but t… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (8 skipped: 8 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
bringing over the approved and lgtm labels over from #2999 |
5f760d7
into
operator-framework:main
1 participant
Description
Part 1/5 of a series completing the
ClusterObjectSet(COS)Readycondition vocabulary.Collapses the two "rolling out" states — the in-transition
RollingOutpath and the per-objectProbeFailurepath — into a singleReady=False/ObjectsNotReadyreason. On the readiness axis these were one state observed at two instants (a pending probe already counts as not-ready), so onereason reads more clearly.
Changes
ClusterObjectSetReasonObjectsNotReady; removeClusterObjectSetReasonProbeFailure. COS no longer emits the sharedRollingOutreason."N object(s) are not yet ready.", or"Objects are not yet ready."before any probe reports); per-object probe detail is logged atV(1)rather than carried on the condition.ProgressDeadlineExceededoverlay still wins, and keeps a generic "last status" so the reconstructedClusterExtensionProgressing message stays stable.progressingFromReadymapsObjectsNotReady→Progressing=True/RollingOut(CE contract unchanged).Scope
Experimental API only. Updates unit tests (status-condition + deadline tables), e2e
status/revision/update/installfeatures, the concept doc, and regenerates the CRD, manifests, and API reference.🤖 Generated with Claude Code
Summary by CodeRabbit
Status Reporting
Documentation