Repository navigation
fix: verify Flatpak bundles during release - #31
Aaqibhafeezkhan wants to merge 1 commit into
Conversation
francescobianco
left a comment
There was a problem hiding this comment.
Thank you @Aaqibhafeezkhan for this contribution, and for picking up two issues at once!
Removing continue-on-error and installing the bundle with flatpak install --bundle + flatpak info means a broken .flatpak can no longer end up silently attached to a release. Passing --runtime-repo also lets users install the bundle without adding Flathub by hand first.
You are now part of the Openapi® ecosystem, and we'd love to see you in our contributors registry: https://github.com/openapi/contributors. Fork it, add your row (main project: openapi/gknowledge), open a PR, and you can put the Openapi® Contributor badge on your profile README.
|
@Aaqibhafeezkhan a few details on where #24 stands, so you can take it all the way if you like: The original error is already gone. The
Points 2 and 3 can go in this PR or in a follow-up, whichever you prefer. A few lines in the PR description with what you reproduced and tested would be enough. And once again: you'd be very welcome in the Openapi® contributors registry → https://github.com/openapi/contributors (add your row with |
I can do them in a follow up? |
francescobianco
left a comment
There was a problem hiding this comment.
@Aaqibhafeezkhan yes, absolutely: a follow-up is perfectly fine. Feel free to open separate PRs for points 2 (pypdf in the Flatpak) and 3 (portal testing); they will be reviewed and merged just like this one.
One small reminder: to be officially recognised as a contributor, please add yourself to our official contributors list. Fork https://github.com/openapi/contributors, add your row with openapi/gknowledge as main project, and open a PR there. Once it's merged you'll show up in the registry and can use the Openapi® Contributor badge on your profile. 🙌
Approving this one, thanks again!
Closes #24