Repository navigation
feat: parse .epub files by reading the XHTML inside (closes #21) - #27
Merged
francescobianco merged 2 commits intoOct 13, 2026
Merged
Conversation
Member
|
Thank you @qiaobochi040726-source for this contribution! 🎉 It's a clean, focused change: stdlib You're warmly invited to become an official Openapi contributor: https://github.com/openapi/contributors 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
An .epub is just a zip of XHTML, so
parsers.parsenow pulls the html/xhtml entries out withzipfileand reuses the existing tag stripping, instead of falling through to the binary best-effort read. Also let the importer accept.epub, otherwiseimport_folderskips it. A broken or non-zip file returns "" like the PDF path does.Tried it:
tests/test_core.pybuilds a tiny epub in tmp_path and runs it through import + ingest, checking the text lands in the source page. Didn't bother with spine/OPF ordering — sorted filenames are good enough for a flat read of the chapters.Drafted with an AI coding assistant and gone over before sending, as CONTRIBUTING asks.