Skip to content

test: account for OpenSSL 4.x changes #66775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

test: account for OpenSSL 4.x changes #66775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/addons/openssl-client-cert-engine/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const fixture = require('../../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');

const { hasOpenSSL } = require('../../common/crypto');

if (hasOpenSSL(4))
common.skip('OpenSSL 4 does not support engines');

const fs = require('fs');
const path = require('path');

Expand Down
5 changes: 5 additions & 0 deletions test/addons/openssl-key-engine/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const fixture = require('../../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');

const { hasOpenSSL } = require('../../common/crypto');

if (hasOpenSSL(4))
common.skip('OpenSSL 4 does not support engines');

const fs = require('fs');
const path = require('path');

Expand Down
7 changes: 3 additions & 4 deletions test/parallel/test-x509-escaping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ const { hasOpenSSL, isBoringSSL } = require('../common/crypto');
})).unref();
}

// The subject MUST NOT be ignored if no dNSName subject alternative name
// TLS MUST NOT ignore the subject if no dNSName subject alternative name
// exists, even if other subject alternative names exist.
{
const key = fixtures.readKey('irrelevant_san_correct_subject-key.pem');
Expand All @@ -485,13 +485,12 @@ const { hasOpenSSL, isBoringSSL } = require('../common/crypto');
assert.strictEqual(certX509.subjectAltName, 'IP Address:1.2.3.4');

// The newer X509Certificate API allows customizing this behavior:
const cnFallback = isBoringSSL ? undefined :
servername;
const cnFallback = isBoringSSL || hasOpenSSL(4, 1) ? undefined : servername;
assert.strictEqual(certX509.checkHost(servername), cnFallback);
assert.strictEqual(certX509.checkHost(servername, { subject: 'default' }),
cnFallback);
assert.strictEqual(certX509.checkHost(servername, { subject: 'always' }),
cnFallback);
isBoringSSL ? undefined : servername);
assert.strictEqual(certX509.checkHost(servername, { subject: 'never' }),
undefined);

Expand Down
Loading