Repository navigation
doc: add doc on when to backport V8 patches to main - #66710
Open
legendecas wants to merge 5 commits into
Open
legendecas wants to merge 5 commits into
legendecas wants to merge 5 commits into
Conversation
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Collaborator
|
Review requested:
|
panva
approved these changes
Oct 13, 2026
joyeecheung
reviewed
Oct 13, 2026
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
lpinca
approved these changes
Oct 13, 2026
aduh95
reviewed
Oct 13, 2026
UlisesGascon
approved these changes
Oct 13, 2026
bnb
approved these changes
Oct 13, 2026
legendecas
force-pushed
the
v8-backport
branch
3 times, most recently
from
October 14, 2026 13:45
ffdff3c to
6f5b7ee
Compare
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
v8-backport
branch
from
October 14, 2026 13:46
6f5b7ee to
45007af
Compare
This was referenced Oct 14, 2026
joyeecheung
reviewed
Oct 14, 2026
aduh95
reviewed
Oct 14, 2026
|
|
||
| If the patch meet the following criteria, it's recommended to backport the patches | ||
| to the V8 upgrade staging branches, instead of `main`: | ||
| to the release staging branches like `v<MAJOR>.x-staging`, instead of `main`: |
Contributor
There was a problem hiding this comment.
Do we need to also remind folks that we typically don't accept PRs targeting LTS staging branches?
Member
Author
There was a problem hiding this comment.
Would you like suggest words? I didn't find any docs saying the criteria on backporting dependency patches specifically.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our dependency maintenance rules (like
automated dependency updaters for security reasons),
the general rule is "don't backport individual V8 patches".
Increasing floating patches on the
deps/v8further delay the pendingV8 upgrade and increase the cost to land the upgrade in time.
The backport should only be applied to certain categories of patches,
like fixing builds, V8 API usages, security issues.
I intentionally make this rule strict as proposed in #66393.
I believe this makes the criteria more clearer in a first instinct,
without too many mental cost on determine if we should backport or not.
Refs: #66393