Skip to content

chore(nav): make beta nav 1:1 main site - #1166

Merged
avivkeller merged 1 commit into
mainfrom
update-nav
Oct 15, 2026
Merged

avivkeller merged 1 commit into
mainfrom
update-nav

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

Make sure that beta nav is the same as nodejs.org

Validation

nodejs.org beta preview
Capture d’écran 2026-10-14 à 16 21 40 Capture d’écran 2026-10-14 à 16 21 49

should be same as nodejs.org but without beta link

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy
AugustinMauroy requested a review from a team as a code owner October 14, 2026 14:20
@vercel

vercel Bot commented Oct 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Oct 14, 2026 2:20pm UTC

Request Review

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅

View logs ↗
No Preview URL. Enable ↗ 3a4e898 2026-10-14T14:20:05.930Z View logs ↗

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (48beb33) to head (3a4e898).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         278      278           
  Lines       27815    27815           
  Branches     2789     2789           
=======================================
  Hits        25993    25993           
  Misses       1800     1800           
  Partials       22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 40.2% slower (870.00 ms → 1.22 s)
  • Peak memory: 0.2% higher (310.44 MB → 311.06 MB)

json Generator

Output: 1 file differs

util.json
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    '$schema': 'https://doc-kit.nodejs.org/schemas/api-doc/1.0.1.json',
    added: [],
    changes: [],
    children: [
...
          "console.log(styleText('#f00', 'Red text'));\n" +
+         '\n' +
+         '// Hex color combined with other modifiers\n' +
+         "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));\n" +
          '```\n' +
          '\n' +
          '```cjs\n' +
          "const { styleText } = require('node:util');\n" +
          '\n' +
...
          "console.log(styleText('#f00', 'Red text'));\n" +
+         '\n' +
+         '// Hex color combined with other modifiers\n' +
+         "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));\n" +
          '```\n' +
          '\n' +
          'The full list of formats can be found in [modifiers](#modifiers).',
        examples: [
          {
...
              '// 3-digit hex color (shorthand)\n' +
+             "console.log(styleText('#f00', 'Red text'));\n" +
+             '\n' +
+             '// Hex color combined with other modifiers\n' +
+             "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));",
-             "console.log(styleText('#f00', 'Red text'));",
            displayName: null,
            language: 'mjs'
          },
          {
            code: "const { styleText } = require('node:util');\n" +
...
              '// 3-digit hex color (shorthand)\n' +
+             "console.log(styleText('#f00', 'Red text'));\n" +
+             '\n' +
+             '// Hex color combined with other modifiers\n' +
+             "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));",
-             "console.log(styleText('#f00', 'Red text'));",
            displayName: null,
            language: 'cjs'
          }
        ],
        id: 'utilstyletextformat-text-options',
...
              default: null,
+             description: 'A text format defined in `util.inspect.colors`,\n' +
+               'a hex color in `#RGB` or `#RRGGBB` form, or an Array of text formats and/or hex colors.',
-             description: 'A text format or an Array\n' +
-               'of text formats defined in `util.inspect.colors`, or a hex color in `#RGB`\n' +
-               'or `#RRGGBB` form.',
              name: 'format',
              optional: false,
              properties: [],
              rest: false,
              type: {

Performance estimate (single CI run)

  • Generation time: 47.9% slower (6.54 s → 9.67 s)
  • Peak memory: 1.5% higher (1.18 GB → 1.20 GB)

legacy-html Generator

Output size: 1 file changed · net +2.38 KB

File size details
File Main PR Change
util.html 803.62 KB 806.00 KB +2.38 KB (+0.3%)

Performance estimate (single CI run)

  • Generation time: 25.9% faster (19.57 s → 14.51 s)
  • Peak memory: 1.1% higher (1.87 GB → 1.89 GB)

legacy-json Generator

Output: 1 file differs

util.json
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    modules: [
      {
        classes: [
          {
...
              "console.log(styleText('#f00', 'Red text'));\n" +
+             '\n' +
+             '// Hex color combined with other modifiers\n' +
+             "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));\n" +
              '</code></pre>\n' +
              `<pre><code class="language-cjs">const { styleText } = require('node:util');\n` +
              '\n' +
              '// 6-digit hex color\n' +
              "console.log(styleText('#ff5733', 'Orange text'));\n" +
...
              "console.log(styleText('#f00', 'Red text'));\n" +
+             '\n' +
+             '// Hex color combined with other modifiers\n' +
+             "console.log(styleText(['#00f', 'bold'], 'Bold blue text'));\n" +
              '</code></pre>\n' +
              '<p>The full list of formats can be found in <a href="#modifiers">modifiers</a>.</p>',
            meta: {
              added: [
                'v21.7.0',
...
                  {
+                   desc: 'A text format defined in `util.inspect.colors`, a hex color in `#RGB` or `#RRGGBB` form, or an Array of text formats and/or hex colors.',
-                   desc: 'A text format or an Array of text formats defined in `util.inspect.colors`, or a hex color in `#RGB` or `#RRGGBB` form.',
                    name: 'format',
+                   textRaw: '`format` {string | Array} A text format defined in `util.inspect.colors`, a hex color in `#RGB` or `#RRGGBB` form, or an Array of text formats and/or hex colors.',
-                   textRaw: '`format` {string | Array} A text format or an Array of text formats defined in `util.inspect.colors`, or a hex color in `#RGB` or `#RRGGBB` form.',
                    type: 'string | Array'
                  },
                  {
                    desc: 'The text to be formatted.',
                    name: 'text',

Performance estimate (single CI run)

  • Generation time: 59.4% slower (6.58 s → 10.49 s)
  • Peak memory: 13.2% lower (1.26 GB → 1.10 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 14.4% faster (9.30 s → 7.96 s)
  • Peak memory: 5.8% higher (1.07 GB → 1.13 GB)

orama-db Generator

Output size: 1 file changed · net +1.00 B

File size details
File Main PR Change
orama-db.json 29.15 MB 29.15 MB +1.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 14.1% faster (10.10 s → 8.68 s)
  • Peak memory: 0.6% higher (1.26 GB → 1.26 GB)

web Generator

Output size: 2 files changed · net +5.37 KB

File size details
File Main PR Change
all.html 34.70 MB 34.70 MB +2.68 KB (+0.0%)
util.html 1.26 MB 1.27 MB +2.68 KB (+0.2%)

Performance estimate (single CI run)

  • Generation time: 9.9% faster (25.42 s → 22.91 s)
  • Peak memory: 2.9% higher (1.95 GB → 2.01 GB)

@avivkeller
avivkeller merged commit 560c042 into main Oct 15, 2026
26 checks passed
@avivkeller
avivkeller deleted the update-nav branch October 15, 2026 14:24

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 3a4e8980 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants