Repository navigation
[Client] Throw InvalidArgumentException for unencodable request params - #592
Merged
chr-hertel merged 1 commit intoOct 14, 2026
Merged
chr-hertel merged 1 commit into
chr-hertel merged 1 commit into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 13, 2026 22:36
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation safely handles both encoding paths and includes focused regression coverage.
0 open findings
What changed in this PR
Ensures JSON encoding failures remain within the SDK exception model and server requests receive an error response.
Changes:
- Wraps request encoding failures in
InvalidArgumentException. - Returns internal errors for unencodable handler responses.
- Adds tests and updates API/error documentation.
| File | Description |
|---|---|
src/Client/Protocol.php |
Handles JSON encoding failures. |
src/Client.php |
Documents the new exception case. |
tests/Unit/Client/ProtocolTest.php |
Tests request and response failures. |
docs/client/errors.md |
Documents client behavior. |
CHANGELOG.md |
Records the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chr-hertel
force-pushed
the
fix-client-json-encode-error
branch
from
October 13, 2026 23:43
bf3c947 to
f091ecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request params with invalid UTF-8 made the client throw a native
\JsonException, outside ofExceptionInterface. A request handler result with invalid UTF-8 left the server's request without an answer.Protocol::send()wraps the\JsonExceptionin anInvalidArgumentExceptionnaming the methodProtocol::sendResponse()logs it and answers with an internal error instead@throwsand the client error docs list the new caseFixes chr-hertel#79
🤖 Generated with Claude Code