Repository navigation
Cherry-pick #64818 into release-7.0 - #64822
Merged
Andrew Branch (andrewbranch) merged 1 commit intoOct 14, 2026
Merged
Andrew Branch (andrewbranch) merged 1 commit into
Andrew Branch (andrewbranch) merged 1 commit into
Conversation
(cherry picked from commit 257e874)
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Platform-specific permissions, cleanup, and Unix path-contract changes require human confirmation of cross-platform validation before release approval.
0 open findings
What changed in this PR
Backports #64818 into release-7.0 to secure API socket and named-pipe creation.
Changes:
- Creates private Unix socket directories with restricted permissions and cleanup.
- Restricts Windows pipe access and randomizes sync API pipe names.
- Adds transport tests and documents the Unix directory-path contract.
| File | Description |
|---|---|
tsc/internal/lsp/server.go |
Creates private transports and returns their actual paths. |
tsc/internal/lsp/lsproto/lsp_generated.go |
Updates generated pipe parameter documentation. |
tsc/internal/lsp/lsproto/_generate/generate.mts |
Updates the source protocol documentation. |
tsc/internal/api/transport.go |
Adds private transport creation and cleanup handling. |
tsc/internal/api/transport_windows.go |
Restricts pipe access to the current user. |
tsc/internal/api/transport_windows_test.go |
Tests connectivity and pipe permissions. |
tsc/internal/api/transport_unix.go |
Creates private socket directories and cleans them up. |
tsc/internal/api/transport_unix_test.go |
Tests permissions, cleanup, and replacement preservation. |
tsc/internal/api/server.go |
Documents Unix pipe-path semantics. |
tsc/cmd/tsc/api.go |
Updates CLI help for private Unix sockets. |
packages/typescript/src/api/syncChannel.ts |
Randomizes Windows sync API pipe names. |
Files not reviewed (1)
- tsc/internal/lsp/lsproto/lsp_generated.go: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Oct 14, 2026
Andrew Branch (andrewbranch)
enabled auto-merge (squash)
October 14, 2026 23:36
Andrew Branch (andrewbranch)
merged commit Oct 14, 2026
e26ac55
into
microsoft:release-7.0
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #64818 into release-7.0