Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64820
Registry.specifierCachewas only cleared whenautoImportSpecifierExcludeRegexeschanged, so a change toimportModuleSpecifierPreferenceorimportModuleSpecifierEndingkept returning specifiers computed with the old preferences for files that were already open.This clears the cache on every user preference change instead of comparing the specific preferences that affect specifiers:
importModuleSpecifierPreferenceandimportModuleSpecifierEndingwere never added to the check. Clearing unconditionally keeps the cache correct when new preferences that affect specifiers are added later.Added
TestAutoImportModuleSpecifierAfterUserPreferenceChange, which changesautoImportSpecifierExcludeRegexes,importModuleSpecifierEndingandimportModuleSpecifierPreferenceone at a time on an open file and checks the auto-import specifier after each change. The first step covers the existing behavior; the other two fail without this change.