Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding prescan skips the declaration following
<!-->or<!--->because it starts searching for-->after the opener’s two hyphens. The HTML prescan algorithm permits those hyphens to form part of the terminator.Start the terminator search two bytes earlier. Add direct prescan and binary-input regressions for both short comments, normal-comment controls, and a declaration inside a comment that must remain ignored. Include CHANGES and AUTHORS entries.
Fixes #427.
Validation: the full suite passes with 17,504 passes, 15,885 skips, and 683 expected failures on Python 3.11; all 197 encoding tests and changed-file Flake8 checks pass. Both short-comment cases fail with unchanged source. The test environment pins setuptools below 81 for the project’s existing pkg_resources dependency.