Repository navigation
Conversation
Signed-off-by: Tomás Migone <tomas@thegraph.foundation>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Since v0.42.0, every Celo block before the Gingerbread hard fork (block 21616000) fails to deserialize due to missing
sha3Unclesfrom block responses, stalling subgraph indexing. See #6738 for more details. This PR fixes that issue. Now Celo transports re-parse block responses to set a default value for the missingsha3Uncles(other chains pay oneeth_chainIdcall per provider).Approach
0x1dcc…. The rust-web3 fork filled in zero. Mappings read the field asethereum.Block.unclesHash, so any other value could change entity data compared with deployments indexed before v0.42.0.eth_chainIdcall.