Repository navigation
Conversation
Releases attach x86_64 and aarch64 Linux binaries (publish.yml) and push the graph-node and graph-node-debug images (docker.yml), which also build nightly from master. Images go to ghcr.io/graphprotocol and, when DOCKERHUB_USERNAME and DOCKERHUB_TOKEN are set, to Docker Hub with the same tags. This replaces the Google Cloud Build setup (docker/cloudbuild.yaml, docker/tag.sh).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #6734 (release-please). When release-please cuts a release, this publishes binaries and Docker images. It also replaces the Google Cloud Build setup.
Binaries (
.github/workflows/publish.yml): buildsgraph-nodeforx86_64andaarch64Linux, cross-compiling the latter, and attaches the gzipped binaries and aSHA256SUMSfile to the release.tag_nameanddry_run. A dry run uploads the bundle as a workflow artifact and leaves the release untouched.GITHUB_TOKENonly.Docker images (
.github/workflows/docker.yml): builds thegraph-nodeandgraph-node-debugtargets ofdocker/Dockerfileforlinux/amd64, with the same build args and tags asdocker/tag.sh:nightlyrelease.yml)vX.Y.Z,latestghcr.io/graphprotocol/graph-nodeandghcr.io/graphprotocol/graph-node-debug.DOCKERHUB_USERNAMEandDOCKERHUB_TOKENare set, the same tags also go to Docker Hubgraphprotocol/graph-node(-debug). Without the token, the "Log in to Docker Hub" step shows as skipped and the images go to ghcr only. Tags come fromdocker/metadata-action.docker-compose.ymlanddocker/README.mdkeep the Docker Hub name.Removed:
docker/cloudbuild.yamlanddocker/tag.sh. Cloud Build is still pushing to Docker Hub today, so its trigger should be disabled when this merges.Before this leaves draft:
DOCKERHUB_USERNAMEandDOCKERHUB_TOKENas repository secrets, for an account with push access tographprotocol/*. Cloud Build pushed aslutter.publish.ymlby hand withdry_run: true, plusdocker.ymlby hand from this branch, which pushes only short-SHA tags.Known and left as is:
nightly) and once from the release (vX.Y.Z,latest); Cloud Build did the same.nightlyhas no concurrency guard, so two master pushes close together can finish out of order.