Skip to content

test(bundler-plugins): Disable CLI telemetry in the CLI contract tests - #25308

Merged
mydea merged 1 commit into
developfrom
test/bundler-plugins-cli-contract-flake
Oct 15, 2026
Merged

mydea merged 1 commit into
developfrom
test/bundler-plugins-cli-contract-flake

Conversation

@mydea

@mydea mydea commented Oct 13, 2026

Copy link
Copy Markdown
Member

The SentryCliAdapter contract tests in bundler-plugins occasionally time out on the first test.

Every command run through the real CLI also sends the CLI's own telemetry to o1.ingest.us.sentry.io and waits up to ~3s for it to flush. With that endpoint unreachable, each test takes ~3s instead of ~80ms, which leaves the first test, which also pays the CLI's cold start, too little headroom under the 5s timeout on a slow runner. Setting SENTRY_CLI_NO_TELEMETRY for the suite brings every test back to a few milliseconds, and the tests no longer send anything to sentry.io.

🤖 Generated with Claude Code

@mydea
mydea requested review from JPeer264, isaacs and timfish October 14, 2026 11:39
Every CLI command waits up to ~3s to flush its telemetry to sentry.io, so
when that endpoint is slow or unreachable the first test, which also pays
the CLI's cold start, runs past the 5s timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea force-pushed the test/bundler-plugins-cli-contract-flake branch from b2da04c to 0889aca Compare October 14, 2026 12:57
@mydea
mydea marked this pull request as ready for review October 14, 2026 13:40

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@mydea
mydea merged commit a309cf8 into develop Oct 15, 2026
273 checks passed
@mydea
mydea deleted the test/bundler-plugins-cli-contract-flake branch October 15, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants