Repository navigation
feat: versioned system agent template (system-agent, OCEAN P05) - #2
Merged
Merged
Conversation
Ship a neutral system agent template as package data and expose it with `githubbot-core --json system-agent` (schema githubbot-core.system-agent/v1): version (= package version), sha256 of the canonical template, capability, effective permissions and a blueprint using the field names of the ellmos agent-studio blueprint payload. The template exists only where the package is installed, which is the capability binding the consumer needs. Policy refs and the model fallback chain are deliberately not part of the template yet; they depend on the consumer contract (BACH/ellmos-system-gui). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LYHP4Js5ggpzQ78JXWRe5E
Review fixes by independent reviewer: version 0.1.0 -> 0.2.0 so tag and template version match; remove product name from template/docs; fix spacing typo in test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LYHP4Js5ggpzQ78JXWRe5E
lukisch
marked this pull request as ready for review
October 11, 2026 08:31
Contributor
Author
|
Review R6 (unabhängiges Zweitmodell, Sonnet 5.5), Kopf geprüft: 418695f, danach Fix eb12c2a. Bereinigte Neufassung des Reviews vom 2026-10-11 08:31 UTC (lokale Pfadangabe entfernt, Prüfsubstanz unverändert).
Befund: bestanden, Merge folgt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
githubbot-core --json system-agentprints a neutral, versioned system agent template shipped as package data (schemagithubbot-core.system-agent/v1):version= package version,sha256= SHA-256 of the canonical template JSON (stable across line endings and hosts)capability={package, version, spi_version}; the template exists only where the package is installedpermissions= the effective, narrowed configuration (--configlayers apply)blueprint= persona, role, contractus, governance, skills using the field names of the ellmos agent-studio blueprint payloadWhy
OCEAN plan P05: the public core delivers the system agent template; BACH/Ocean show it only when the capability is installed. Binding the template to the installed package is that capability check. Consumers pin
version+sha256and must not overwrite an existing agent when a newer template appears.Not included on purpose: policy refs,
inherits_fromand the ordered model fallback chain. They depend on the consumer contract that does not exist yet (agent-studio has no route to register package-provided system templates, nopolicy_refs, no model chain). They are planned as additive fields once that contract lands.Checks
pytest -q: 143 passed, 1 skipped (consumer install test, runs in CI); consumer install test locally withGITHUBBOT_CORE_CONSUMER_TEST=1: passed (template ships as package data)ruff check .: cleanis_templaterejected; materialize mapping givesread_file,list_directory,search_text, safe mode, 15 tool rounds, one-shot workerDraft until reviewed by a different model. Do not merge without that review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LYHP4Js5ggpzQ78JXWRe5E