Skip to content

fix(scanner): trim HTML comment bang endings from TODO labels - #3

Draft
lukisch wants to merge 1 commit into
mainfrom
fix/todo-comment-end-20261015
Draft

lukisch wants to merge 1 commit into
mainfrom
fix/todo-comment-end-20261015

Conversation

@lukisch

@lukisch lukisch commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

An HTML TODO ending with --!> retained that closing marker in its displayed task text. Recognize this alternative HTML comment ending alongside --> and the existing C block ending. The regression exercises the real file scanner and preserves unsupported endings, literal markup, mid-text markers, author, line number and original line text.

The new regression fails on the exact main base and all seven scanner/panel tests pass after the two-line production change. Focused Ruff and diff checks pass. Runtime version and dependencies are unchanged. Exact-head CI is required.

This addresses the comment-end pattern reported by CodeQL alert4 in core/todo_scanner.py. That code cleans labels and is not an HTML sanitizer; no exploitable XSS or general HTML-sanitization guarantee is established. The existing alert remains governed by GitHub analysis; it was not dismissed.

Author model: gpt-6.1-sol (Codex). Independent review pending. Draft only; merges disabled. No release or runtime mirror update.

Author model: gpt-6.1-sol (Codex). Independent review pending.
@github-actions

Copy link
Copy Markdown

Welcome! 👋 Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant