Repository navigation
fix(ssh): write Windows ProxyCommand paths with forward slashes - #1157
Merged
Merged
Conversation
EhabY
force-pushed
the
fix/windows-proxycommand-forward-slashes
branch
from
October 15, 2026 10:52
3458188 to
3254e10
Compare
Lisa-Fiander
approved these changes
Oct 15, 2026
Lisa-Fiander
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1156 (stacked on it; retargets to
mainonce #1156 merges).What's fixed
On Windows, open-remote-ssh v0.4.0 (the current Open VSX release, used by VSCodium and similar editors) treats
\in aProxyCommandas an escape, so every path reached the CLI without separators (C:UsersJohn Doe…) and the connection failed. 1.16.4 is affected too.How
escapeProxyCommandPathwrites Windows drive-letter paths with/for the binary,--global-config,--network-info-dir,--log-dir, and the legacy token and URL files. UNC (\\server) and\\?\paths are unchanged.sh, both open-remote-ssh versions and Positron all accept/.globalConfig != config.DefaultDir()incli/root.go) is unaffected, because the extension's own folder is never the default.sshviaremote.SSH.path), Cursor and VSCodium (open-remote-ssh 0.4.0): all connect. The nativeremote.test.tstest uses a drive path on Windows CI.This is a workaround until open-remote-ssh 0.4.1 ships the upstream fix (jeanp413/open-remote-ssh#342);
/keeps working after that. Related: jeanp413/open-remote-ssh#377.Generated by Coder Agents on behalf of @EhabY.