Skip to content

feature/add german national lib - #111

Merged
codebude merged 3 commits into
developfrom
feature/add-german-national-lib
Oct 15, 2026
Merged

codebude merged 3 commits into
developfrom
feature/add-german-national-lib

Conversation

@codebude

Copy link
Copy Markdown
Owner
  • Add Deutsche Nationalbibliothek as book import source
  • Add Deutsche Nationalbibliothek to import search frontend
  • Document Deutsche Nationalbibliothek import source

@codebude codebude self-assigned this Oct 15, 2026
@github-actions

Copy link
Copy Markdown

🧪 Test Results — bc04722

✅ Backend (pytest) — 1175 passed, 0 failed, 0 skipped (1175 total)
✅ CLI (pytest) — 54 passed, 0 failed, 0 skipped (54 total)
✅ Frontend (vitest) — 543 passed, 0 failed, 0 skipped (543 total)
✅ E2E (Playwright) — 79 passed, 0 failed, 0 skipped (79 total)

Summary: ✅ All 1851 tests passed

@mj0nez

mj0nez commented Oct 15, 2026

Copy link
Copy Markdown

Nice, works as expected! Only covers are not yet fetched. :)

@codebude

Copy link
Copy Markdown
Owner Author

@mj0nez the dnb SRU api does not provide cover images. I believe they intentionally do not provide images, because:

The basis for displaying cover images in the DNB catalogue is an agreement between the German Library Association (dbv) and the collecting society VG Bild-Kunst. The agreement allows libraries to use the cover service of the VLB (German Books in Print).

Source: https://www.dnb.de/EN/Professionell/Metadatendienste/Kataloganreicherung/Cover/cover.html?nn=1936038#doc1936034bodyText1

Therefore I would skip covers from dnb here and point to the both cover search features of LibrisLog:

@codebude
codebude merged commit 06c4ed7 into develop Oct 15, 2026
5 checks passed
@codebude
codebude deleted the feature/add-german-national-lib branch October 15, 2026 21:59
@mj0nez

mj0nez commented Oct 15, 2026

Copy link
Copy Markdown

Fair, thanks for implementing this on such a short notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants