Repository navigation
CI: Cancel stale merge queue runs + use ubuntu-slim - #4106
Open
rambleraptor wants to merge 1 commit into
Open
rambleraptor wants to merge 1 commit into
rambleraptor wants to merge 1 commit into
Conversation
A PR re-added to the merge queue reuses the same queue branch, so its runs waited behind the previous attempt's still-queued runs in the same concurrency group. Cancel in-progress runs for merge_group as well. Run the license check on ubuntu-slim to reduce demand for ubuntu-latest runners. That image has no Java, so install it explicitly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We're having trouble merging in #4100. The ultimate issue is a lack of ubuntu-latest runners, but there's a couple easy wins we can get to help out.
cancel-in-progressonly works on PRs, which makes sense in a pre-merge queue world. We should open it up everywhere, so that merge queue runs aren't stalled forever.ubuntu-slimwhen possible. That image has very little baked in, so it's really hard for us to do in practice. The license checker is the easiest win, so let's go ahead and give that a try.Are these changes tested?
We expect CI to still work + we're hoping that this will help merging in #4100 on the edges.
Are there any user-facing changes?