Skip to content

keep other clusters' acl rules when deleting a cks cluster on a vpc - #14424

Draft
Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:fix-cks-vpc-acl-delete
Draft

Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:fix-cks-vpc-acl-delete

Conversation

@Damans227

Copy link
Copy Markdown
Collaborator

Fixes #14409

Deleting a CKS cluster on a VPC tier removed every allow rule for ports 6443 and 22 in the tier's ACL list, so other clusters using the same list lost their rules. The rules CKS added had nothing tying them to a cluster. Now each rule CKS adds gets the cluster's id in its reason, and delete only removes the rules with that id. For clusters made before this change, whose rules have no reason, delete removes one rule per port instead of all of them.

Test:

Added unit tests with three 6443 rules in one ACL list: one for cluster A, one for cluster B, one older rule with no reason. Then delete cluster A's rules..

@Damans227

Copy link
Copy Markdown
Collaborator Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 20.40%. Comparing base (d3f0700) to head (f38b135).

Files with missing lines Patch % Lines
...KubernetesClusterResourceModifierActionWorker.java 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14424   +/-   ##
=========================================
  Coverage     20.39%   20.40%           
- Complexity    21283    21287    +4     
=========================================
  Files          6481     6481           
  Lines        588040   588052   +12     
  Branches      72021    72022    +1     
=========================================
+ Hits         119957   119970   +13     
+ Misses       455052   455045    -7     
- Partials      13031    13037    +6     
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 21.70% <92.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19586

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CKS on VPC: deleting a cluster removes ACL rules used by other clusters

2 participants