Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #14408 +/- ##
=============================================
- Coverage 20.39% 3.70% -16.70%
=============================================
Files 6481 493 -5988
Lines 588040 42544 -545496
Branches 72021 8065 -63956
=============================================
- Hits 119957 1577 -118380
+ Misses 455052 40741 -414311
+ Partials 13031 226 -12805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nvazquez
reviewed
Oct 15, 2026
Pearl1594
reviewed
Oct 15, 2026
Pearl1594
approved these changes
Oct 15, 2026
Pearl1594
left a comment
Contributor
There was a problem hiding this comment.
code lgtm - havent tested this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11596
With a private registry set, a new CKS cluster stays in Starting. The control node setup script for the registry is wrapped in
{% if registry is defined %}, butregistryis never a cloud-init variable. The server fills in the registry details as plain text, so the check is never true and the script is never written. The server still swaps the line that writes the containerd config for a call to that script, so containerd keeps its default config with the image service off and kubeadm never runs. This keeps the jinja header and changes the check to{% if "{{ registry.enabled }}" == "true" %}, and the server fills in true or false when it builds the user data.Test:
Added unit tests for a cluster with and without a registry. The lab run below was on the first commit.
On a KVM lab with 2 hosts and
cloud.kubernetes.cluster.experimental.features.enabled=true, create a CKS cluster (v1.36.0, 1 control node, 1 worker) withdockerregistryurl=https://index.docker.io/v1/and a registry username and password.Before: the cluster stays in Starting. On the control node:
After: the cluster goes to Running and both nodes are Ready. On the control node: