Repository navigation
ui: handle empty network offerings without Request failed (#14377) - #14399
Open
nabassa1323 wants to merge 1 commit into
Open
nabassa1323 wants to merge 1 commit into
nabassa1323 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Damans227
reviewed
Oct 14, 2026
| this.networkOfferings = json.listnetworkofferingsresponse.networkoffering || [] | ||
| this.networkOfferings = this.networkOfferings.filter(offering => offering.fornsx === this.selectedZone.isnsxenabled) | ||
| if (!this.selectedZone.routedmodeenabled) { | ||
| const offerings = json?.listnetworkofferingsresponse?.networkoffering || [] |
Collaborator
There was a problem hiding this comment.
looks like #13503 already fixed the crash on the isolated tab for 4.22 and main. does it still show request failed on main without this change?
Damans227
reviewed
Oct 14, 2026
| this.networkOfferings = [] | ||
| getAPI('listNetworkOfferings', params).then(json => { | ||
| this.networkOfferings = json.listnetworkofferingsresponse.networkoffering || [] | ||
| const offerings = json?.listnetworkofferingsresponse?.networkoffering || [] |
Collaborator
There was a problem hiding this comment.
the shared tab already handles an empty list here in 4.22.1.0. which request fails on that tab in the browser network tab?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Add Network UI showing "Request failed" when Isolated/Shared
have no enabled network offerings (empty/null listNetworkOfferings response).
Shows a clear warning instead. Does not hide guest-type tabs (separate
enhancement from #14377).
Fixes: #14377 (UI error handling part only)
Types of changes
How to test