Skip to content

kvm: fix security group conntrack NOTRACK optimization for single-direction allow-all rules #14100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weizhouapache wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −16
Open

kvm: fix security group conntrack NOTRACK optimization for single-direction allow-all rules #14100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698614a
kvm: fix security group conntrack NOTRACK optimization triggered by s…
weizhouapache Sep 9, 2026
824f92a
kvm: keep conntrack disabled for security groups with allow-all ingre…
weizhouapache Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions scripts/vm/network/security_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,23 +1136,33 @@ def add_network_rules(vm_name, vm_id, vm_ip, vm_ip6, signature, seqno, vmMac, ru
ip4s, ip6s = split_ips_by_family(vm_ip, vm_ip6, sec_ips, str(ipv6_link_local_addr(vmMac)))

rules = parse_network_rules(rules)
conntrack4_not_needed = False
conntrack6_not_needed = False
ingress4_allow_all = False
egress4_allow_all = False
ingress6_allow_all = False
egress6_allow_all = False
Comment on lines +1139 to +1142
egress4_has_rules = False
egress6_has_rules = False
for rule in rules:
"""
If any of the rules has an explicit allow all protocols from 0.0.0.0/0 (ipv4)
or ::/0 (ipv6), then that IP family doesn't need its connection tracked
Example contents of the rules list:
[
{'ipv4': ['1.0.0.0/24', '0.0.0.0/0'], 'ipv6': ['::/0'], 'ruletype': 'I', 'start': 0, 'end': 0, 'protocol': 'all'},
{'ipv4': ['1.1.1.1/32'], 'ipv6': [], 'ruletype': 'I', 'start': 1, 'end': 65535, 'protocol': 'tcp'},
{'ipv4': [], 'ipv6': ['2001:db8::/32'], 'ruletype': 'I', 'start': 2000, 'end': 3000, 'protocol': 'tcp'}
]
"""
if '0.0.0.0/0' in rule['ipv4'] and rule['protocol'].lower() == 'all':
conntrack4_not_needed = True
if '::/0' in rule['ipv6'] and rule['protocol'].lower() == 'all':
conntrack6_not_needed = True
if rule['ruletype'] == 'E':
egress4_has_rules = egress4_has_rules or bool(rule['ipv4'])
egress6_has_rules = egress6_has_rules or bool(rule['ipv6'])
Comment on lines +1147 to +1148
if rule['protocol'].lower() == 'all':
if '0.0.0.0/0' in rule['ipv4']:
if rule['ruletype'] == 'E':
egress4_allow_all = True
else:
ingress4_allow_all = True
if '::/0' in rule['ipv6']:
if rule['ruletype'] == 'E':
egress6_allow_all = True
else:
ingress6_allow_all = True

# The NOTRACK rules apply to the IP in both directions, so conntrack can only be skipped when
# ingress allows all and egress is open as well: either an explicit allow-all egress rule or no
# egress rules at all (the egress chain then accepts everything).
conntrack4_not_needed = ingress4_allow_all and (egress4_allow_all or not egress4_has_rules)
conntrack6_not_needed = ingress6_allow_all and (egress6_allow_all or not egress6_has_rules)
Comment on lines +1161 to +1165

if conntrack4_not_needed:
add_to_ipset(NOTRACK_IPV4_IPSET, ip4s, "add")
Expand Down
Loading