Repository navigation
fix(@schematics/angular): show routing module suffixes in findModule error - #34374
Merged
Merged
Conversation
…` error When only routing modules are found, the error message printed the optional `routingModuleExt` parameter, which no schematic passes, so users saw "Modules with suffix 'undefined' are strictly reserved for routing.". Since 0b7d48c the lookup checks both `-routing-module.ts` and `-routing.module.ts`, so list the suffixes that are actually used.
alan-agius4
added
the
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the error message in find-module.ts to dynamically list all reserved routing module suffixes, and adds a corresponding unit test in find-module_spec.ts to verify the error message format. There are no review comments, and we have no feedback to provide.
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only routing modules are found, the error message printed the optional
routingModuleExtparameter, which no schematic passes, so users saw "Modules with suffix 'undefined' are strictly reserved for routing.". Since 0b7d48c the lookup checks both-routing-module.tsand-routing.module.ts, so list the suffixes that are actually used.