Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GS1-128's compact numeric encoding can make the bars narrower than their human-readable caption. For example,
Gs1_128("00376401856400470087", writer=ImageWriter()).render()creates a 428-pixel-wide image at the default settings, clipping both ends of a caption that needs about 494 pixels.Measure text bounds in
ImageWriterand expand its canvas horizontally when needed. Move the existing pixels together so module sizes and the relative positions of the bars and caption blocks stay intact. Reset the translation for each render. Add pixel comparisons for multiline captions, both text positions, guarded EAN text blocks, transparent backgrounds, and writer reuse; document the possible increase in image width.Fixes #229. This addresses horizontal clipping in
ImageWriter; #212's vertical size/text-distance changes are independent.Validation:
AI-assisted implementation and validation.