Repository navigation
Keep namespaces in dependency source labels - #405
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
Identify scoped dependency ancestors correctly in package and alert reports. Preserve manifest paths and existing traversal behavior. Assisted-by: Codex:GPT-6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
Show npm scopes and Maven groups when identifying which dependency introduced a package or alert.
Root Cause
Ancestor labels omitted the stored namespace. Distinct dependencies such as
@one/widgetand@two/widgetappeared under the same label and could collapse in rendered reports.Fix
Builds on #404. No schema or release changes.
Validation
30 focused tests pass, including real model tests and actual Core/SDK requests against the approved localhost fixture. Scoped lint, test formatting, and diff checks pass. Independent source review found no blockers.
Public Changelog
Preserve package scopes and groups in dependency source labels.
Note
Low Risk
Single-path string formatting in provenance labeling with broad test coverage; no API or schema changes.
Overview
Fixes “introduced by” labels for transitive dependencies and alerts so top-level ancestors are identified with their namespace/scope (e.g.
npm/@one/widget@1.0.0vsnpm/@two/widget@1.0.0), not bare package names that could collide.Core.get_source_datanow builds ancestor labels from ecosystem, optionalnamespace, name, and version; manifest paths and traversal order are unchanged. The corrected tuples flow through alert issues,Messages.create_sources, and JSONintroduced_byonnew_packages/new_alerts.Adds unit tests for
get_source_dataand an integration test (diff-scan and streaming fallback) that scoped roots and multi-ancestor transitives serialize correctly.Reviewed by Cursor Bugbot for commit 313bcc1. Configure here.