Skip to content

4.x: Isolate Maybe amb and concat race tests - #8329

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
JimmyLiuJia:codex/maintenance/8075-maybe-amb-concat-isolation
Oct 14, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
JimmyLiuJia:codex/maintenance/8075-maybe-amb-concat-isolation

Conversation

@JimmyLiuJia

Copy link
Copy Markdown
Contributor

Related #8075.

Move five existing race tests from MaybeAmbTest, MaybeConcatArrayTest, and MaybeConcatIterableTest into their corresponding @Isolated test classes. The test bodies, race loops, assertions, and cleanup remain unchanged.

Validation: targeted tests for all six affected classes, validators, and checkstyleTest passed locally.

AI assistance: Codex helped identify and move the tests, run validation, and prepare this PR. The changes were reviewed before submission.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.798 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbIsolatedTest.java: 4.689
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbTest.java: 4.639
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayIsolatedTest.java: 4.959
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayTest.java: 4.675
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatIterableIsolatedTest.java: 4.940
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatIterableTest.java: 4.885

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (1ef5930) to head (f935239).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8329      +/-   ##
============================================
- Coverage     98.63%   98.63%   -0.01%     
+ Complexity     7157     7155       -2     
============================================
  Files           824      824              
  Lines         50822    50822              
  Branches       6920     6920              
============================================
- Hits          50129    50126       -3     
  Misses          471      471              
- Partials        222      225       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd
akarnokd merged commit 9529995 into ReactiveX:4.x Oct 14, 2026
8 checks passed
@akarnokd akarnokd added this to the 4.0 milestone Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants