Skip to content

fix(netdev): correct ping delay logic for last packet and avoid rt_thread_delay(0) - #11866

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
ymj0440:fix-netdev-ping-delay
Oct 15, 2026
Merged

fix(netdev): correct ping delay logic for last packet and avoid rt_thread_delay(0)#11866
Rbb666 merged 1 commit into
RT-Thread:masterfrom
ymj0440:fix-netdev-ping-delay

Conversation

@ymj0440

@ymj0440 ymj0440 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

摘要 Summary

修复 netdev_cmd_ping() 中 ping 间隔时延的两处缺陷：

  1. 循环内 index == times 恒为假，导致最后一次 ping 后仍会补时延，与原注释意图不符；
  2. delay_tick 为 0 时仍调用 rt_thread_delay(0)，该调用会返回 -RT_EINVAL。

修改为：记录实际耗时 cost_tick，用 index != times - 1 判断是否最后一轮，且仅当 delay_tick > 0 时才调用 rt_thread_delay()。

Fixes #11865

改动文件 Changes

  • components/net/netdev/src/netdev.c (+14/-4)

检查清单 Check List

  • 源码格式与 RT-Thread coding style 一致
  • 编译验证通过（bsp/simulator）
  • 未修改 BSP 的 rtconfig.h 等无关文件

@ymj0440
fix(netdev): correct ping delay logic for last packet and avoid rt_th…
6876152 
…read_delay(0)

The 'index == times' condition in the delay_tick calculation is never true,
so the delay was still applied after the last ping, contrary to the comment.
Skip the delay on the final ping by checking 'index != times - 1'.

Also only call rt_thread_delay() when delay_tick > 0, since passing 0
returns -RT_EINVAL.
@ymj0440 ymj0440 mentioned this pull request Oct 14, 2026
Closed
9 tasks done
@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支（通常为 master）
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix-netdev-ping-delay
    Enter PR branch fix-netdev-ping-delay in the branch field
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 fix-netdev-ping-delay 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-netdev-ping-delay branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/net/netdev/src/netdev.c

📊 Current Review Status (Last Updated: 2026-10-14 10:14 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

nuvoton-m487

  • CODE: .text +16 B (+0.0%, 356,040 B / 524,288 B, total: 68% used)

simulator

@Rbb666
Rbb666 merged commit 20881ec into RT-Thread:master Oct 15, 2026
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees

No one assigned

Labels

component: net/netdev component: net Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [netdev] ping still applies delay after the last packet and calls rt_thread_delay(0) returning -RT_EINVAL

2 participants

@ymj0440 @Rbb666