Skip to content

fix(audio-context): build on iOS without @nativescript/canvas #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triniwiz merged 1 commit into from
Oct 9, 2026
Merged

fix(audio-context): build on iOS without @nativescript/canvas #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/audio-context/platforms/ios/build.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
OTHER_LDFLAGS = $(inherited) -framework "AVFoundation" -framework "Accelerate" -framework "MediaToolbox" -framework "AudioToolbox" -framework "CoreMedia" -framework "AudioContextNative"

// V8 14.9's headers use C++20 concepts/requires-clauses (e.g. v8-internal.h).
CLANG_CXX_LANGUAGE_STANDARD = c++20

// AudioModule.mm includes the runtime's Runtime.h, whose headers include V8 by bare name
// ("v8.h", "v8config.h"), so the NativeScriptV8 shim's Headers/include must be on the path
// itself - the same reason @nativescript/canvas's build.xcconfig adds it, which used to
// mask this when both plugins were installed. Passed as -I flags rather than
// HEADER_SEARCH_PATHS, which the CLI's xcconfig merge would let drop the CocoaPods paths,
// and named apart from canvas's so both plugins' flags are kept. Two roots, as in canvas:
// an installed plugin, and this monorepo's demo apps (where the shim isn't materialised).
AUDIO_CONTEXT_V8_HEADERS_NPM = $(SRCROOT)/../../node_modules/@nativescript/audio-context/platforms/ios/NativeScriptV8/Headers/include
AUDIO_CONTEXT_V8_HEADERS_MONOREPO = $(SRCROOT)/../../../../nativescript-v8/Headers/include
AUDIO_CONTEXT_V8_HEADER_FLAGS = -I"$(AUDIO_CONTEXT_V8_HEADERS_NPM)" -I"$(AUDIO_CONTEXT_V8_HEADERS_MONOREPO)"
OTHER_CFLAGS = $(inherited) $(AUDIO_CONTEXT_V8_HEADER_FLAGS)
OTHER_CPLUSPLUSFLAGS = $(inherited) $(AUDIO_CONTEXT_V8_HEADER_FLAGS)
Loading