Repository navigation
feat(arc): run the controller and listeners under the platform priority class when asked - #86
Merged
Merged
Conversation
…ty class when asked A listener is one pod per scale set that ARC cannot replicate, and while it waits to be scheduled no new jobs are assigned, so one that was rescheduled on a full node waited behind runner pods at the default priority. An upgrade also reschedules every controller replica together. github_runner_arc_control_pods_priority_enabled puts the controller and each listener under the PriorityClass the role already creates for the platform's pods, so a pending listener can take a node's room from a runner pod, whose job ARC retries. It is off by default, as it changes what a full node evicts. Closes #84
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
github_runner_arc_control_pods_priority_enabled, off by default like the listener probes beside it. With it on, the controller's values and each scale set'slistenerTemplatecarrypriorityClassNameset to the platform's class (github_runner_arc_platform_priority_class_name), which the role already creates inmain.ymlwhether or not the platform is installed, so nothing new is created.A pending listener can then take a full node's room from a runner pod, whose job ARC retries, instead of waiting behind it. An upgrade reschedules every controller replica together, so the controller gets the same class.
The overlay's
listenerTemplateblock is now rendered when only this option is on. Tests render the overlay and, through a small second playbook, the controller values, for the option on, off and with another class name. The unit suite andansible-lint --profile productionpass.Closes #84