Repository navigation
Harden Agentless Feature Flags EVP delivery - #12477
Open
leoromanovsky wants to merge 10 commits into
Open
leoromanovsky wants to merge 10 commits into
leoromanovsky wants to merge 10 commits into
Conversation
Add capability-gated local discovery, safe sticky direct fallback, shared route state, send-once semantics, and bounded lifecycle handling for Java Feature Flags telemetry. Environment: Datadog workspace
leoromanovsky
added
type: feature
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Move identity attribution to a follow-up branch while keeping forwarding-capability requirements explicit and independent of emitted headers. Preserve credential isolation, no-replay coverage, and existing lifecycle hardening. Validation: communication tests 234/234 and feature-flagging-lib tests 279/279 pass; scoped Spotless formatting passes. Environment: Datadog workspace
leoromanovsky
marked this pull request as ready for review
September 21, 2026 14:42
leoromanovsky
requested review from
bric3,
btthomas,
pavlokhrebto and
vandonr
and removed request for
a team
September 21, 2026 14:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Please try again by commenting @autotest review.
dougqh
reviewed
Sep 22, 2026
dougqh
left a comment
dougqh
left a comment
Contributor
There was a problem hiding this comment.
🤖 Generated with Claude Code
Environment: Datadog workspace
Gate shutdown instrumentation on tracing or resolved feature flag enablement, and share Agent path joining. Pin recovery generations, discovery concurrency, replay, idle recovery, and disabled-product behavior with regression tests. Environment: Datadog workspace
leoromanovsky
requested review from
typotter and
vjfridge
and removed request for
btthomas and
pavlokhrebto
October 7, 2026 02:58
leoromanovsky
added this pull request to stack #12771
October 7, 2026 15:24
aarsilv
reviewed
Oct 8, 2026
vjfridge
reviewed
Oct 8, 2026
vjfridge
left a comment
vjfridge
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes! I think the shutdown scope and build-dependent instrumentation mask need to be resolved before merging. I’ve added comments on those concerns and the combined shutdown wait.
Merge master 9ddc963 before review regressions and repairs. Environment: Datadog workspace
Restore shared Agent URL compatibility, retain bounded pre-send Remote Config retries, and scope Feature Flagging shutdown to activated providers. Signal writers before sharing the native shutdown deadline; avoid interrupting sends and repeated unavailable-route errors. Add wire, lifecycle, and production-wiring regressions. SDK identity forwarding requirements move with identity emission in the child PR.
Include the validated shutdown probe readiness correction for asynchronous Java 8 agent startup. Environment: Datadog workspace
Keep exposure enqueueing lock-free and shutdown best effort. Preserve the existing bounded wait and avoid interrupting HTTP sends. Add a deterministic regression for a producer paused inside an offer. Environment: Datadog workspace
Exercise deadline expiry, caller interruption, in-flight delivery, and worker startup failure without weakening coverage thresholds. Environment: Datadog workspace
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java already delivers agentless exposures (#12195) and flag evaluations (#12204) directly to EVP. This follow-up closes reliability gaps found while checking the cross-SDK contract: unsafe replay, inconsistent writer routes, lost Agent URL prefixes and permanent disablement when no route exists at startup. Tracks FFLSDK-187.
Changes
Decisions
Validation
3110972ccf744f304a7cf59973e240f9ccd1a071.1b5766b56c67bb7151a084abb752e62e5bb4b332../gradlew :communication:spotlessApply :products:feature-flagging:feature-flagging-lib:spotlessApply :communication:test :products:feature-flagging:feature-flagging-lib:test --console=plain --max-workers=4: PASS; communication 234/234, feature-flagging-lib 279/279.git diff --check: PASS. New scope-reduction commit is GitHub verified:verified=true,reason=valid.e20a9d77c333ddb0c0444835f23fafba70952373and must not be carried forward as current proof.