Skip to content

fix: keep the user's HOME when wrapping commands with sudo #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvaroqui merged 1 commit into from
Oct 16, 2026
Merged

fix: keep the user's HOME when wrapping commands with sudo #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/executor/helpers/run_with_sudo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ pub fn wrap_with_sudo(mut cmd_builder: CommandBuilder) -> Result<CommandBuilder>
[
// Password prompt should not appear here since it has already been validated
OsStr::new("--non-interactive"),
// Both forms are needed: sudo-rs ignores the bare flag, and with only the
// list classic sudo keeps `env_reset`, which lets variables exported by PAM
// session modules (e.g. HOME from pam_systemd) override the preserved ones.
OsStr::new("--preserve-env"),
&preserve_env_arg(&cmd_builder),
],
);
Expand Down
Loading