Repository navigation
[examples] Remove old Spring example demo-service - #3211
Merged
Merged
Conversation
examples/demo-spring-service (added in #3096) replaces the old examples/demo-service Spring Boot example. Remove the old example and point the README and the client docs to the new one. Drop examples/demo-service/pom.xml from the example compile list in jvm-compatibility.yml. Without this change the weekly job fails because the POM file no longer exists. Closes #3111 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3111
examples/demo-spring-service(added in #3096) replaces the oldexamples/demo-serviceSpring Boot example. This PR removes the old example and points all links to the new one.Important
This PR changes one CI workflow file.
AGENTS.mdrestricts changes to.github/workflows/**, so I call it out here for explicit approval..github/workflows/jvm-compatibility.ymlcompilesexamples/demo-service/pom.xmlin its "Compile examples" step. After the directory is removed,mvn -f examples/demo-service/pom.xmlfails on every JDK 17+ leg of the weekly run. The change removes only that one line. It must land in the same PR as the directory removal, otherwise the scheduled job stays broken until a follow-up merges. If you prefer to make the workflow change yourself, tell me and I will drop that hunk.Changes
examples/demo-service/(17 files). This is almost all of the ~900 deleted lines.README.md: the "Spring Demo Service" link now points toexamples/demo-spring-service.docs/clickhouse-docs/client.mdx: the two links toexamples/demo-service(in "Examples" and "Usage Examples") now point toexamples/demo-spring-service. The "Usage Examples" description now says what the new example shows (client and JDBC driver in Spring Boot, with observability)..github/workflows/jvm-compatibility.yml: removeexamples/demo-service/pom.xmlfrom the JDK 17+ example list (see the note above).history/latest/3111.md: changelog fragment.Out of scope, not changed:
run_examples.ymlusesdemo-service-dbonly as a Docker container name. It buildsexamples/jdbcand has no path dependency on the removed directory.examples/client-v2/.../NumbersRecord.javauses the package namecom.clickhouse.demo_service.data. It is self-contained in theclient-v2example and nothing imports from the removed directory.examples/demo-spring-service/pom.xmlto thejvm-compatibility.ymllist, because that would add new CI coverage.build.ymlalready compiles everyexamples/*/pom.xmlon pull requests, so the new example still gets compile coverage. I can add it to the weekly list in a follow-up if you want.Test
git grepfinds no remaining reference toexamples/demo-service, thecom.clickhouse.demo_serviceclasses from the removed directory, or its POM (rootpom.xml, docs,navigation.json, workflows).jvm-compatibility.ymlstill parses as valid YAML. The bash array in the edited step is unchanged except for the removed line.build.yml"Compile examples" step compiles the remaining examples on this PR.Checklist
history/latest/3111.md)docs/clickhouse-docs/client.mdx, which syncs to the website)docs/features.md: not applicable (noclient-v2/jdbc-v2behavior change).🤖 Generated with Claude Code