Repository navigation
Fix fabricated source duration in OTIO exports - #580
Open
nikhiljangid120 wants to merge 1 commit into
Open
nikhiljangid120 wants to merge 1 commit into
nikhiljangid120 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop declaring every source media file as exactly 1,980 frames long in OTIO exports.
write_scene_list_otioreceives selected scene ranges, but not the source's full duration. The currentExternalReference.1.available_rangealways starts at zero and lasts 1,980 frames regardless of the source. This can declare exported clips (for example, frames 2,400–4,800) outside the media's available range.Represent the unknown media available range as
null, which OpenTimelineIO supports. Leave each clip'ssource_range, frame rate, media target, and track layout unchanged. A scene subset's final frame should not be substituted for the full source duration.Regression coverage
Validation
trimmed_range()checks pass for all 16 combinations without changing clip timing.ruff check .,ruff format --check ., andgit diff --checkpass.test_fan_out_n1_matches_single_consumer, which retains both full decoded videos. Withtest_fan_out_n1_matches_single_consumerandtest_fan_out_frame_equality_across_consumersexcluded, the broader suite completes: 477 passed, 3 skipped, 85 deselected (83 default release-test deselections plus these 2 exclusions), Python 3.12.15. No claim of a fully passing complete suite.Prepared and tested with AI assistance. No claim of independent human line-by-line review.